• Filipe Manana's avatar
    btrfs: fix leak of source device allocation state after device replace · 611ccc58
    Filipe Manana authored
    When a device replace finishes, the source device is freed by calling
    btrfs_free_device() at btrfs_rm_dev_replace_free_srcdev(), but the
    allocation state, tracked in the device's alloc_state io tree, is never
    freed.
    
    This is a regression recently introduced by commit f0bb5474 ("btrfs:
    remove redundant release of btrfs_device::alloc_state"), which removed a
    call to extent_io_tree_release() from btrfs_free_device(), with the
    rationale that btrfs_close_one_device() already releases the allocation
    state from a device and btrfs_close_one_device() is always called before
    a device is freed with btrfs_free_device(). However that is not true for
    the device replace case, as btrfs_free_device() is called without any
    previous call to btrfs_close_one_device().
    
    The issue is trivial to reproduce, for example, by running test btrfs/027
    from fstests:
    
      $ ./check btrfs/027
      $ rmmod btrfs
      $ dmesg
      (...)
      [84519.395485] BTRFS info (device sdc): dev_replace from <missing disk> (devid 2) to /dev/sdg started
      [84519.466224] BTRFS info (device sdc): dev_replace from <missing disk> (devid 2) to /dev/sdg finished
      [84519.552251] BTRFS info (device sdc): scrub: started on devid 1
      [84519.552277] BTRFS info (device sdc): scrub: started on devid 2
      [84519.552332] BTRFS info (device sdc): scrub: started on devid 3
      [84519.552705] BTRFS info (device sdc): scrub: started on devid 4
      [84519.604261] BTRFS info (device sdc): scrub: finished on devid 4 with status: 0
      [84519.609374] BTRFS info (device sdc): scrub: finished on devid 3 with status: 0
      [84519.610818] BTRFS info (device sdc): scrub: finished on devid 1 with status: 0
      [84519.610927] BTRFS info (device sdc): scrub: finished on devid 2 with status: 0
      [84559.503795] BTRFS: state leak: start 1048576 end 1351614463 state 1 in tree 1 refs 1
      [84559.506764] BTRFS: state leak: start 1048576 end 1347420159 state 1 in tree 1 refs 1
      [84559.510294] BTRFS: state leak: start 1048576 end 1351614463 state 1 in tree 1 refs 1
    
    So fix this by adding back the call to extent_io_tree_release() at
    btrfs_free_device().
    
    Fixes: f0bb5474 ("btrfs: remove redundant release of btrfs_device::alloc_state")
    Reviewed-by: default avatarQu Wenruo <wqu@suse.com>
    Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    611ccc58
volumes.c 217 KB