• Mikulas Patocka's avatar
    parisc: fix unaligned accesses in BPF · 1fd2c10a
    Mikulas Patocka authored
    There were spurious unaligned access warnings when calling BPF code.
    Sometimes, the warnings were triggered with any incoming packet, making
    the machine hard to use.
    
    The reason for the warnings is this: on parisc64, pointers to functions
    are not really pointers to functions, they are pointers to 16-byte
    descriptor. The first 8 bytes of the descriptor is a pointer to the
    function and the next 8 bytes of the descriptor is the content of the
    "dp" register. This descriptor is generated in the function
    bpf_jit_build_prologue.
    
    The problem is that the function bpf_int_jit_compile advertises 4-byte
    alignment when calling bpf_jit_binary_alloc, bpf_jit_binary_alloc
    randomizes the returned array and if the array happens to be not aligned
    on 8-byte boundary, the descriptor generated in bpf_jit_build_prologue is
    also not aligned and this triggers the unaligned access warning.
    
    Fix this by advertising 8-byte alignment on parisc64 when calling
    bpf_jit_binary_alloc.
    Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarHelge Deller <deller@gmx.de>
    1fd2c10a
bpf_jit_core.c 4.63 KB