• Johannes Berg's avatar
    mac80211: fix duplicate retransmission detection · 6b0f3274
    Johannes Berg authored
    The duplicate retransmission detection code in mac80211
    erroneously attempts to do the check for every frame,
    even frames that don't have a sequence control field or
    that don't use it (QoS-Null frames.)
    
    This is problematic because it causes the code to access
    data beyond the end of the SKB and depending on the data
    there will drop packets erroneously.
    
    Correct the code to not do duplicate detection for such
    frames.
    
    I found this error while testing AP powersave, it lead
    to retransmitted PS-Poll frames being dropped entirely
    as the data beyond the end of the SKB was always zero.
    
    Cc: stable@vger.kernel.org [all versions]
    Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
    6b0f3274
rx.c 93.4 KB