• Arjan van de Ven's avatar
    es1968: fix sleep-while-holding-lock bug · 4b47c971
    Arjan van de Ven authored
    snd_es1968_ac97_read() calls snd_es1968_ac97_wait() first outside a locked
    area, and later, while holding a lock.
    
    snd_es1968_ac97_wait() has a polling loop with a cond_resched() inside it..
    which sleeps, so the second call is invalid.
    
    This patch adds a version of the wait function that just pure polls.  While
    this is not very elegant in principle, it's very likely the easiest thing to
    do here, we already checked if the chip was ready (while yielding) just
    before, so it is very unlikely to take a long time here.
    
    [akpm@linux-foundation.org: coding-style fixes]
    Signed-off-by: default avatarArjan van de Ven <arjan@linux.intel.com>
    Cc: Jaroslav Kysela <perex@suse.cz>
    Cc: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    4b47c971
es1968.c 74 KB