• Lorenzo Bianconi's avatar
    ath9k: fix decrypt_error initialization in ath_rx_tasklet() · e1352fde
    Lorenzo Bianconi authored
    ath_rx_tasklet() calls ath9k_rx_skb_preprocess() and ath9k_rx_skb_postprocess()
    in a loop over the received frames. The decrypt_error flag is
    initialized to false
    just outside ath_rx_tasklet() loop. ath9k_rx_accept(), called by
    ath9k_rx_skb_preprocess(),
    only sets decrypt_error to true and never to false.
    Then ath_rx_tasklet() calls ath9k_rx_skb_postprocess() and passes
    decrypt_error to it.
    So, after a decryption error, in ath9k_rx_skb_postprocess(), we can
    have a leftover value
    from another processed frame. In that case, the frame will not be marked with
    RX_FLAG_DECRYPTED even if it is decrypted correctly.
    When using CCMP encryption this issue can lead to connection stuck
    because of CCMP
    PN corruption and a waste of CPU time since mac80211 tries to decrypt an already
    deciphered frame with ieee80211_aes_ccm_decrypt.
    Fix the issue initializing decrypt_error flag at the begging of the
    ath_rx_tasklet() loop.
    Signed-off-by: default avatarLorenzo Bianconi <lorenzo.bianconi83@gmail.com>
    Cc: <stable@kernel.org>
    Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
    e1352fde
recv.c 32.9 KB