• Guenter Roeck's avatar
    Revert "hwmon: (pmbus) Add regulator supply into macro" · 1e699e17
    Guenter Roeck authored
    This reverts commit 54cc3dbf.
    
    Zev Weiss reports that the reverted patch may cause a regulator
    undercount. Here is his report:
    
    ... having regulator-dummy set as a supply on my PMBus regulators
    (instead of having them as their own top-level regulators without
    an upstream supply) leads to enable-count underflow errors when
    disabling them:
    
        # echo 0 > /sys/bus/platform/devices/efuse01/state
        [  906.094477] regulator-dummy: Underflow of regulator enable count
        [  906.100563] Failed to disable vout: -EINVAL
        [  136.992676] reg-userspace-consumer efuse01: Failed to configure state: -22
    
    Zev reports that reverting the patch fixes the problem. So let's do that
    for now.
    
    Fixes: 54cc3dbf ("hwmon: (pmbus) Add regulator supply into macro")
    Cc: Marcello Sylvester Bauer <sylv@sylv.io>
    Reported-by: default avatarZev Weiss <zev@bewilderbeest.net>
    Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
    1e699e17
pmbus.h 15.1 KB