• Trond Myklebust's avatar
    SUNRPC: Fix read ordering problems with req->rq_private_buf.len · 1e799b67
    Trond Myklebust authored
    We want to ensure that req->rq_private_buf.len is updated before
    req->rq_received, so that call_decode() doesn't use an old value for
    req->rq_rcv_buf.len.
    
    In 'call_decode()' itself, instead of using task->tk_status (which is set
    using req->rq_received) must use the actual value of
    req->rq_private_buf.len when deciding whether or not the received RPC reply
    is too short.
    
    Finally ensure that we set req->rq_rcv_buf.len to zero when retrying a
    request. A typo meant that we were resetting req->rq_private_buf.len in
    call_decode(), and then clobbering that value with the old rq_rcv_buf.len
    again in xprt_transmit().
    Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
    1e799b67
clnt.c 37 KB