• David Rientjes's avatar
    oom: kill all threads sharing oom killed task's mm · 1e99bad0
    David Rientjes authored
    It's necessary to kill all threads that share an oom killed task's mm if
    the goal is to lead to future memory freeing.
    
    This patch reintroduces the code removed in 8c5cd6f3 (oom: oom_kill
    doesn't kill vfork parent (or child)) since it is obsoleted.
    
    It's now guaranteed that any task passed to oom_kill_task() does not share
    an mm with any thread that is unkillable.  Thus, we're safe to issue a
    SIGKILL to any thread sharing the same mm.
    
    This is especially necessary to solve an mm->mmap_sem livelock issue
    whereas an oom killed thread must acquire the lock in the exit path while
    another thread is holding it in the page allocator while trying to
    allocate memory itself (and will preempt the oom killer since a task was
    already killed).  Since tasks with pending fatal signals are now granted
    access to memory reserves, the thread holding the lock may quickly
    allocate and release the lock so that the oom killed task may exit.
    
    This mainly is for threads that are cloned with CLONE_VM but not
    CLONE_THREAD, so they are in a different thread group.  Non-NPTL threads
    exist in the wild and this change is necessary to prevent the livelock in
    such cases.  We care more about preventing the livelock than incurring the
    additional tasklist in the oom killer when a task has been killed.
    Systems that are sufficiently large to not want the tasklist scan in the
    oom killer in the first place already have the option of enabling
    /proc/sys/vm/oom_kill_allocating_task, which was designed specifically for
    that purpose.
    
    This code had existed in the oom killer for over eight years dating back
    to the 2.4 kernel.
    
    [akpm@linux-foundation.org: add nice comment]
    Signed-off-by: default avatarDavid Rientjes <rientjes@google.com>
    Acked-by: default avatarKAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    Cc: Rik van Riel <riel@redhat.com>
    Cc: Ying Han <yinghan@google.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    1e99bad0
oom_kill.c 21.2 KB