• Eric Dumazet's avatar
    net: rfs: enable RFS before first data packet is received · 1eddcead
    Eric Dumazet authored
    Le jeudi 16 juin 2011 à 23:38 -0400, David Miller a écrit :
    > From: Ben Hutchings <bhutchings@solarflare.com>
    > Date: Fri, 17 Jun 2011 00:50:46 +0100
    >
    > > On Wed, 2011-06-15 at 04:15 +0200, Eric Dumazet wrote:
    > >> @@ -1594,6 +1594,7 @@ int tcp_v4_do_rcv(struct sock *sk, struct sk_buff *skb)
    > >>  			goto discard;
    > >>
    > >>  		if (nsk != sk) {
    > >> +			sock_rps_save_rxhash(nsk, skb->rxhash);
    > >>  			if (tcp_child_process(sk, nsk, skb)) {
    > >>  				rsk = nsk;
    > >>  				goto reset;
    > >>
    > >
    > > I haven't tried this, but it looks reasonable to me.
    > >
    > > What about IPv6?  The logic in tcp_v6_do_rcv() looks very similar.
    >
    > Indeed ipv6 side needs the same fix.
    >
    > Eric please add that part and resubmit.  And in fact I might stick
    > this into net-2.6 instead of net-next-2.6
    >
    
    OK, here is the net-2.6 based one then, thanks !
    
    [PATCH v2] net: rfs: enable RFS before first data packet is received
    
    First packet received on a passive tcp flow is not correctly RFS
    steered.
    
    One sock_rps_record_flow() call is missing in inet_accept()
    
    But before that, we also must record rxhash when child socket is setup.
    Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
    CC: Tom Herbert <therbert@google.com>
    CC: Ben Hutchings <bhutchings@solarflare.com>
    CC: Jamal Hadi Salim <hadi@cyberus.ca>
    Signed-off-by: default avatarDavid S. Miller <davem@conan.davemloft.net>
    1eddcead
tcp_ipv4.c 66.2 KB