• Willem de Bruijn's avatar
    net: compound page support in skb_seq_read · 97550f6f
    Willem de Bruijn authored
    skb_seq_read iterates over an skb, returning pointer and length of
    the next data range with each call.
    
    It relies on kmap_atomic to access highmem pages when needed.
    
    An skb frag may be backed by a compound page, but kmap_atomic maps
    only a single page. There are not enough kmap slots to always map all
    pages concurrently.
    
    Instead, if kmap_atomic is needed, iterate over each page.
    
    As this increases the number of calls, avoid this unless needed.
    The necessary condition is captured in skb_frag_must_loop.
    
    I tried to make the change as obvious as possible. It should be easy
    to verify that nothing changes if skb_frag_must_loop returns false.
    
    Tested:
      On an x86 platform with
        CONFIG_HIGHMEM=y
        CONFIG_DEBUG_KMAP_LOCAL_FORCE_MAP=y
        CONFIG_NETFILTER_XT_MATCH_STRING=y
    
      Run
        ip link set dev lo mtu 1500
        iptables -A OUTPUT -m string --string 'badstring' -algo bm -j ACCEPT
        dd if=/dev/urandom of=in bs=1M count=20
        nc -l -p 8000 > /dev/null &
        nc -w 1 -q 0 localhost 8000 < in
    Signed-off-by: default avatarWillem de Bruijn <willemb@google.com>
    Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    97550f6f
skbuff.c 157 KB