• Arnd Bergmann's avatar
    Input: analog - fix invalid snprintf() call · 1f59342b
    Arnd Bergmann authored
    Overlapping input and output arguments to snprintf() are
    undefined behavior in C99:
    
    drivers/input/joystick/analog.c: In function 'analog_name':
    drivers/input/joystick/analog.c:428:3: error: 'snprintf' argument 4 overlaps destination object 'analog' [-Werror=restrict]
      428 |   snprintf(analog->name, sizeof(analog->name), "%s %d-hat",
          |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      429 |     analog->name, hweight16(analog->mask & ANALOG_HATS_ALL));
          |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    drivers/input/joystick/analog.c:420:40: note: destination object referenced by 'restrict'-qualified argument 1 was declared here
      420 | static void analog_name(struct analog *analog)
          |                         ~~~~~~~~~~~~~~~^~~~~~
    
    Change this function to use the simpler seq_buf interface instead.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Link: https://lore.kernel.org/r/20210927101416.1569609-1-arnd@kernel.orgSigned-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
    1f59342b
analog.c 19.6 KB