• david decotigny's avatar
    forcedeth: fix TX timeout caused by TX pause on down link · 1ff39eb6
    david decotigny authored
    On some dual-port forcedeth devices such as MCP55 10de:0373 (rev a3),
    when autoneg & TX pause are enabled while port is connected but
    interface is down, the NIC will eventually freeze (TX timeouts,
    network unreachable).
    
    This patch ensures that TX pause is not configured in hardware when
    interface is down. The TX pause request will be honored when interface
    is later configured.
    
    Tested:
     - hardware is MCP55 device id 10de:0373 (rev a3), dual-port
     - eth0 connected and UP, eth1 connected but DOWN
     - without this patch, following sequence would brick NIC:
          ifconfig eth0 down
          ifconfig eth1 up
          ifconfig eth1 down
          ethtool -A eth1 autoneg off rx on tx off
          ifconfig eth1 up
          ifconfig eth1 down
          ethtool -A eth1 autoneg on rx on tx on
          ifconfig eth1 up
          ifconfig eth1 down
          ifup eth0
          sleep 120  # or longer
          ethtool eth1
       Just in case, sequence to un-brick:
          ifconfig eth0 down
          ethtool -A eth1 autoneg off rx on tx off
          ifconfig eth1 up
          ifconfig eth1 down
          ifup eth0
     - with this patch: no TX timeout after "bricking" sequence above
    
    Details:
     - The following register accesses have been identified as the ones
       causing the NIC to freeze in "bricking" sequence above:
        - write NVREG_TX_PAUSEFRAME_ENABLE_V1 to eth1's register NvRegTxPauseFrame
        - write NVREG_MISC1_PAUSE_TX | NVREG_MISC1_FORCE to eth1's register NvRegMisc1
        - write 0 to eth1's register NvRegTransmitterControl
       This is what this patch avoids.
    Signed-off-by: default avatarDavid Decotigny <decot@googlers.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    1ff39eb6
forcedeth.c 188 KB