• Eryu Guan's avatar
    CIFS: iterate over posix acl xattr entry correctly in ACL_to_cifs_posix() · ae9ebe7c
    Eryu Guan authored
    Commit 2211d5ba ("posix_acl: xattr representation cleanups")
    removes the typedefs and the zero-length a_entries array in struct
    posix_acl_xattr_header, and uses bare struct posix_acl_xattr_header
    and struct posix_acl_xattr_entry directly.
    
    But it failed to iterate over posix acl slots when converting posix
    acls to CIFS format, which results in several test failures in
    xfstests (generic/053 generic/105) when testing against a samba v1
    server, starting from v4.9-rc1 kernel. e.g.
    
      [root@localhost xfstests]# diff -u tests/generic/105.out /root/xfstests/results//generic/105.out.bad
      --- tests/generic/105.out       2016-09-19 16:33:28.577962575 +0800
      +++ /root/xfstests/results//generic/105.out.bad 2016-10-22 15:41:15.201931110 +0800
      @@ -1,3 +1,4 @@
       QA output created by 105
       -rw-r--r-- root
      +setfacl: subdir: Invalid argument
       -rw-r--r-- root
    
    Fix it by introducing a new "ace" var, like what
    cifs_copy_posix_acl() does, and iterating posix acl xattr entries
    over it in the for loop.
    Signed-off-by: default avatarEryu Guan <guaneryu@gmail.com>
    Signed-off-by: default avatarSteve French <smfrench@gmail.com>
    ae9ebe7c
cifssmb.c 192 KB