• Thor Thayer's avatar
    mtd: spi-nor: cadence-quadspi: Fix page fault kernel panic · 47016b34
    Thor Thayer authored
    The current Cadence QSPI driver caused a kernel panic when loading
    a Root Filesystem from QSPI. The problem was caused by reading more
    bytes than needed because the QSPI operated on 4 bytes at a time.
    <snip>
    [    7.947754] spi_nor_read[1048]:from 0x037cad74, len 1 [bfe07fff]
    [    7.956247] cqspi_read[910]:offset 0x58502516, buffer=bfe07fff
    [    7.956247]
    [    7.966046] Unable to handle kernel paging request at virtual
    address bfe08002
    [    7.973239] pgd = eebfc000
    [    7.975931] [bfe08002] *pgd=2fffb811, *pte=00000000, *ppte=00000000
    </snip>
    Notice above how only 1 byte needed to be read but by reading 4 bytes
    into the end of a mapped page, an unrecoverable page fault occurred.
    
    This patch uses a temporary buffer to hold the 4 bytes read and then
    copies only the bytes required into the buffer. A min() function is
    used to limit the length to prevent buffer overflows.
    
    Request testing of this patch on other platforms. This was tested
    on the Intel Arria10 SoCFPGA DevKit.
    
    Fixes: 0cf17256 ("mtd: spi-nor: cqspi: Fix build on arches missing readsl/writesl")
    Signed-off-by: default avatarThor Thayer <thor.thayer@linux.intel.com>
    Cc: <stable@vger.kernel.org>
    Reviewed-by: default avatarMarek Vasut <marek.vasut@gmail.com>
    Signed-off-by: default avatarBoris Brezillon <boris.brezillon@bootlin.com>
    47016b34
cadence-quadspi.c 35.6 KB