• Lee Jones's avatar
    misc: habanalabs: goya: Omit pointless check ensuring addr is >=0 · 2557f27f
    Lee Jones authored
    Seeing as 'addr' is unsigned, it would be impossible for the assigned
    value to be anything other than zero or positive.
    
    Squashes the following W=1 warnings:
    
     drivers/misc/habanalabs/goya/goya.c: In function ‘goya_debugfs_read32’:
     drivers/misc/habanalabs/goya/goya.c:3945:19: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
     3945 | } else if ((addr >= DRAM_PHYS_BASE) &&
     | ^~
     drivers/misc/habanalabs/goya/goya.c: In function ‘goya_debugfs_write32’:
     drivers/misc/habanalabs/goya/goya.c:4002:19: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
     4002 | } else if ((addr >= DRAM_PHYS_BASE) &&
     | ^~
     drivers/misc/habanalabs/goya/goya.c: In function ‘goya_debugfs_read64’:
     drivers/misc/habanalabs/goya/goya.c:4047:19: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
     4047 | } else if ((addr >= DRAM_PHYS_BASE) &&
     | ^~
     drivers/misc/habanalabs/goya/goya.c: In function ‘goya_debugfs_write64’:
     drivers/misc/habanalabs/goya/goya.c:4091:19: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
     4091 | } else if ((addr >= DRAM_PHYS_BASE) &&
     | ^~
     drivers/misc/habanalabs/pci.c:328: warning: Excess function parameter 'dma_mask' description in 'hl_pci_set_dma_mask'
     drivers/misc/habanalabs/goya/goya_coresight.c: In function ‘goya_debug_coresight’:
     drivers/misc/habanalabs/goya/goya_coresight.c:643:6: warning: variable ‘val’ set but not used [-Wunused-but-set-variable]
     643 | u32 val;
     | ^~~
    
    Cc: Oded Gabbay <oded.gabbay@gmail.com>
    Cc: Tomer Tayar <ttayar@habana.ai>
    Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
    Reviewed-by: default avatarOded Gabbay <oded.gabbay@gmail.com>
    Link: https://lore.kernel.org/r/20200701085853.164358-7-lee.jones@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    2557f27f
goya.c 144 KB