• Steven Rostedt's avatar
    ktest.pl: Add RUN_TIMEOUT option with default unlimited · 4e7d2a8f
    Steven Rostedt authored
    There is a disconnect between the run_command function and the
    wait_for_input. The wait_for_input has a default timeout of 2 minutes. But
    if that happens, the run_command loop will exit out to the waitpid() of
    the executing command. This fails in that it no longer monitors the
    command, and also, the ssh to the test box can hang when its finished, as
    it's waiting for the pipe it's writing to to flush, but the loop that
    reads that pipe has already exited, leaving the command stuck, and the
    test hangs.
    
    Instead, make the default "wait_for_input" of the run_command infinite,
    and allow the user to override it if they want with a default timeout
    option "RUN_TIMEOUT".
    
    But this fixes the hang that happens when the pipe is full and the ssh
    session never exits.
    
    Cc: stable@vger.kernel.org
    Fixes: 6e98d1b4 ("ktest: Add timeout to ssh command")
    Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
    4e7d2a8f
sample.conf 49.6 KB