• Linus Walleij's avatar
    ASoC: ux500: drop platform DAI assignments · f1013cde
    Linus Walleij authored
    This platform is completely probed by device tree nowadays, so
    we need to do a bigger cleanup removing all the non-DT codepaths.
    This cleanup must however go in as a fix since it fixes a
    regression.
    
    Currently when Ux500 audio is enabled, dmesg complains like
    this:
    
    entry->name == "prealloc"
    entry->name == "prealloc_max"
    entry->name == "prealloc"
    ------------[ cut here ]------------
    WARNING: CPU: 0 PID: 95 at ../fs/proc/generic.c:346
    proc_register+0xf0/0x110
    proc_dir_entry 'sub0/prealloc' already registered
    (...)
    entry->name == "prealloc_max"
    ------------[ cut here ]------------
    WARNING: CPU: 0 PID: 95 at ../fs/proc/generic.c:346
    proc_register+0xf0/0x110
    proc_dir_entry 'sub0/prealloc_max' already registered
    (...)
    snd-soc-mop500 soc:sound: ab8500-codec-dai.0 <->
    80124000.msp mapping ok
    entry->name == "prealloc"
    entry->name == "prealloc_max"
    entry->name == "prealloc"
    ------------[ cut here ]------------
    WARNING: CPU: 0 PID: 95 at ../fs/proc/generic.c:346
    proc_register+0xf0/0x110
    proc_dir_entry 'sub0/prealloc' already registered
    (...)
    entry->name == "prealloc_max"
    ------------[ cut here ]------------
    WARNING: CPU: 0 PID: 95 at ../fs/proc/generic.c:346
    proc_register+0xf0/0x110
    proc_dir_entry 'sub0/prealloc_max' already registered
    snd-soc-mop500 soc:sound: ab8500-codec-dai.1 <->
    80125000.msp mapping ok
    
    This is because PCMs are created twice for the same hardware,
    and this happens because both "platform" and "CPU" DAI links
    are specified.
    
    But platform/CPU is an either/or pair, not a both/and pair.
    This has maybe worked in the past, but it is causing trouble
    now, so let us begin the cleanups by removing the platform
    assignment and silencing the boot noise, and make a proper DT
    cleanup for the next kernel cycle.
    
    Cc: Ulf Hansson <ulf.hansson@linaro.org>
    Cc: Lee Jones <lee.jones@linaro.org>
    Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    f1013cde
mop500.c 3.87 KB