• Florian Fainelli's avatar
    MIPS: Kbuild: Do not allow building vmlinuz when !ZBOOT · 26fca83a
    Florian Fainelli authored
    When CONFIG_SYS_SUPPORTS_ZBOOT is not enabled, we will still try to
    build the decompressor code in arch/mips/boot/compressed as a
    dependency for producing the vmlinuz target and this will result in
    the following build failure:
    
      OBJCOPY arch/mips/boot/compressed/vmlinux.bin
    arch/mips/boot/compressed/decompress.c: In function 'decompress_kernel':
    arch/mips/boot/compressed/decompress.c:105:2: error: implicit
    declaration of function 'decompress'
    make[1]: *** [arch/mips/boot/compressed/decompress.o] Error 1
    make[1]: *** Waiting for unfinished jobs....
    make: *** [vmlinuz] Error 2
    
    This is a genuine build failure because we have no implementation for
    the decompress() function body since no kernel compression method
    defined in CONFIG_KERNEL_(GZIP,BZIP2...) has been enabled.
    
    arch/mips/Makefile already guards the install target for the "vmlinuz"
    binary with a proper ifdef CONFIG_SYS_SUPPORTS_ZBOOT, we now also do the
    same if we attempt to do a "make vmlinuz" and show that
    CONFIG_SYS_SUPPORTS_ZBOOT is not enabled.
    
    [ralf@linux-mips.org: Cleanup the makefile rule as suggested by James
    Hogan.]
    Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
    Reviewed-by: default avatarJames Hogan <james.hogan@imgtec.com>
    Cc: linux-mips@linux-mips.org
    Cc: blogic@openwrt.org
    Cc: richard@nod.at
    Patchwork: https://patchwork.linux-mips.org/patch/5817/Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
    26fca83a
Makefile 11.3 KB