• Johan Korsnes's avatar
    HID: core: fix off-by-one memset in hid_report_raw_event() · 5ebdffd2
    Johan Korsnes authored
    In case a report is greater than HID_MAX_BUFFER_SIZE, it is truncated,
    but the report-number byte is not correctly handled. This results in a
    off-by-one in the following memset, causing a kernel Oops and ensuing
    system crash.
    
    Note: With commit 8ec321e9 ("HID: Fix slab-out-of-bounds read in
    hid_field_extract") I no longer hit the kernel Oops as we instead fail
    "controlled" at probe if there is a report too long in the HID
    report-descriptor. hid_report_raw_event() is an exported symbol, so
    presumabely we cannot always rely on this being the case.
    
    Fixes: 966922f2 ("HID: fix a crash in hid_report_raw_event()
                         function.")
    Signed-off-by: default avatarJohan Korsnes <jkorsnes@cisco.com>
    Cc: Armando Visconti <armando.visconti@st.com>
    Cc: Jiri Kosina <jkosina@suse.cz>
    Cc: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
    5ebdffd2
hid-core.c 64.2 KB