• Stefan Richter's avatar
    firewire: core: don't fail device creation in case of too large config ROM blocks · 2799d5c5
    Stefan Richter authored
    It never happened yet, but better safe than sorry:  If a device's config
    ROM contains a block which overlaps the boundary at 0xfffff00007ff, just
    ignore that one block instead of refusing to add the device
    representation.  That way, upper layers (kernelspace or userspace
    drivers) might still be able to use the device to some degree.
    
    That's better than total inaccessibility of the device.  Worse, the core
    would have logged only a generic "giving up on config rom" message which
    could only be debugged by feeding a firewire-ohci debug logging session
    through a config ROM interpreter, IOW would likely remain undiagnosed.
    Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
    2799d5c5
core-device.c 33.3 KB