• Srinivas Kandagatla's avatar
    [media] media: lirc: Allow lirc dev to talk to rc device · ca7a722d
    Srinivas Kandagatla authored
    The use case is simple, if any rc device has allowed protocols =
    RC_TYPE_LIRC and map_name = RC_MAP_LIRC set, the driver open will be never
    called. The reason for this is, all of the key maps except lirc have some
    KEYS in there map, so during rc_register_device process these keys are
    matched against the input drivers and open is performed, so for the case
    of RC_MAP_EMPTY, a vt/keyboard is matched and the driver open is
    performed.
    In case of lirc, there is no match and result is that there is no open
    performed, however the lirc-dev will go ahead and create a /dev/lirc0
    node. Now when lircd/mode2 opens this device, no data is available
    because the driver was never opened.
    Other case pointed by Sean Young, As rc device gets opened via the
    input interface. If the input device is never opened (e.g. embedded with
    no console) then the rc open is never called and lirc will not work
    either. So that's another case.
    lirc_dev seems to have no link with actual rc device w.r.t open/close.
    This patch adds rc_dev pointer to lirc_driver structure for cases like
    this, so that it can do the open/close of the real driver in accordance
    to lircd/mode2 open/close.
    Without this patch its impossible to open a rc device which has
    RC_TYPE_LIRC ad RC_MAP_LIRC set.
    Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@st.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
    ca7a722d
ir-lirc-codec.c 9.44 KB