• Michael Ellerman's avatar
    radix tree test suite: Fix build with --as-needed · 284d96a4
    Michael Ellerman authored
    Currently the radix tree test suite doesn't build with toolchains that
    use --as-needed by default, for example Ubuntu's:
    
      cc -I. -I../../include -g -O2 -Wall -D_LGPL_SOURCE -fsanitize=address -lpthread -lurcu main.o ... -o main
      /usr/bin/ld: regression1.o: undefined reference to symbol 'pthread_join@@GLIBC_2.17'
      /lib/powerpc64le-linux-gnu/libpthread.so.0: error adding symbols: DSO missing from command line
      collect2: error: ld returned 1 exit status
    
    This is caused by the custom makefile rules placing LDFLAGS before the
    .o files that need the libraries.
    
    We could fix it by using --no-as-needed, or rewriting the custom rules.
    But we can also just drop the custom rules and move the libraries to
    LDLIBS, and then the default rules work correctly - with the one caveat
    that we need to add -fsanitize=address to LDFLAGS because that must be
    passed to the linker as well as the compiler.
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    Signed-off-by: default avatarMatthew Wilcox <mawilcox@microsoft.com>
    284d96a4
Makefile 1.19 KB