• Kefeng Wang's avatar
    mm: move memory_failure_queue() into copy_mc_[user]_highpage() · 28bdacbc
    Kefeng Wang authored
    Patch series "mm: migrate: support poison recover from migrate folio", v5.
    
    The folio migration is widely used in kernel, memory compaction, memory
    hotplug, soft offline page, numa balance, memory demote/promotion, etc,
    but once access a poisoned source folio when migrating, the kernel will
    panic.
    
    There is a mechanism in the kernel to recover from uncorrectable memory
    errors, ARCH_HAS_COPY_MC(eg, Machine Check Safe Memory Copy on x86), which
    is already used in NVDIMM or core-mm paths(eg, CoW, khugepaged, coredump,
    ksm copy), see copy_mc_to_{user,kernel}, copy_mc_{user_}highpage callers.
    
    This series of patches provide the recovery mechanism from folio copy for
    the widely used folio migration.  Please note, because folio migration is
    no guarantee of success, so we could chose to make folio migration
    tolerant of memory failures, adding folio_mc_copy() which is a #MC
    versions of folio_copy(), once accessing a poisoned source folio, we could
    return error and make the folio migration fail, and this could avoid the
    similar panic shown below.
    
      CPU: 1 PID: 88343 Comm: test_softofflin Kdump: loaded Not tainted 6.6.0
      pc : copy_page+0x10/0xc0
      lr : copy_highpage+0x38/0x50
      ...
      Call trace:
       copy_page+0x10/0xc0
       folio_copy+0x78/0x90
       migrate_folio_extra+0x54/0xa0
       move_to_new_folio+0xd8/0x1f0
       migrate_folio_move+0xb8/0x300
       migrate_pages_batch+0x528/0x788
       migrate_pages_sync+0x8c/0x258
       migrate_pages+0x440/0x528
       soft_offline_in_use_page+0x2ec/0x3c0
       soft_offline_page+0x238/0x310
       soft_offline_page_store+0x6c/0xc0
       dev_attr_store+0x20/0x40
       sysfs_kf_write+0x4c/0x68
       kernfs_fop_write_iter+0x130/0x1c8
       new_sync_write+0xa4/0x138
       vfs_write+0x238/0x2d8
       ksys_write+0x74/0x110
    
    
    This patch (of 5):
    
    There is a memory_failure_queue() call after copy_mc_[user]_highpage(),
    see callers, eg, CoW/KSM page copy, it is used to mark the source page as
    h/w poisoned and unmap it from other tasks, and the upcomming poison
    recover from migrate folio will do the similar thing, so let's move the
    memory_failure_queue() into the copy_mc_[user]_highpage() instead of
    adding it into each user, this should also enhance the handling of
    poisoned page in khugepaged.
    
    Link: https://lkml.kernel.org/r/20240626085328.608006-1-wangkefeng.wang@huawei.com
    Link: https://lkml.kernel.org/r/20240626085328.608006-2-wangkefeng.wang@huawei.comSigned-off-by: default avatarKefeng Wang <wangkefeng.wang@huawei.com>
    Reviewed-by: default avatarJane Chu <jane.chu@oracle.com>
    Reviewed-by: default avatarMiaohe Lin <linmiaohe@huawei.com>
    Cc: Alistair Popple <apopple@nvidia.com>
    Cc: Benjamin LaHaise <bcrl@kvack.org>
    Cc: David Hildenbrand <david@redhat.com>
    Cc: Hugh Dickins <hughd@google.com>
    Cc: Jérôme Glisse <jglisse@redhat.com>
    Cc: Jiaqi Yan <jiaqiyan@google.com>
    Cc: Lance Yang <ioworker0@gmail.com>
    Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
    Cc: Muchun Song <muchun.song@linux.dev>
    Cc: Naoya Horiguchi <nao.horiguchi@gmail.com>
    Cc: Oscar Salvador <osalvador@suse.de>
    Cc: Tony Luck <tony.luck@intel.com>
    Cc: Vishal Moola (Oracle) <vishal.moola@gmail.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    28bdacbc
ksm.c 105 KB