• Tony Lindgren's avatar
    mfd: twl-core: Fix idle mode signaling for omaps when booted with device tree · a613b739
    Tony Lindgren authored
    I noticed a regression where the omap sys_clkreq signal will never
    trigger for omap3 when booted with device tree while it triggers
    when booted in legacy mode. This means voltage scaling does not
    do anything when booted with device tree.
    
    Turns out the reason is we fail to initialize the SmartReflex
    enable bit in twl4030 with the following error:
    
    twl: not initialized
    
    And that happens because we are wrongly tinkering with the twl4030
    registers in arch/arm/mach-omap2/omap_twl.c before the driver is
    initialized. Looking at the the SmartReflex bit enable code in
    omap_twl.c, we need to always set it.
    
    So let's fix the issue by always enabling the twl4030 SmartReflex
    bit in the drivers/mfd/twl-core.c probe, and drop the related
    code in omap_twl.c.
    
    Note that we still have some twl4030 tinkering left in omap_twl.c
    for the twl6030 case, but that's a different patch.
    Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
    Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
    a613b739
omap_twl.c 6.94 KB