• Nick Desaulniers's avatar
    riscv: mm: fix 2 instances of -Wmissing-variable-declarations · d2402048
    Nick Desaulniers authored
    I'm looking to enable -Wmissing-variable-declarations behind W=1. 0day
    bot spotted the following instance in ARCH=riscv builds:
    
      arch/riscv/mm/init.c:276:7: warning: no previous extern declaration
      for non-static variable 'trampoline_pg_dir'
      [-Wmissing-variable-declarations]
      276 | pgd_t trampoline_pg_dir[PTRS_PER_PGD] __page_aligned_bss;
          |       ^
      arch/riscv/mm/init.c:276:1: note: declare 'static' if the variable is
      not intended to be used outside of this translation unit
      276 | pgd_t trampoline_pg_dir[PTRS_PER_PGD] __page_aligned_bss;
          | ^
      arch/riscv/mm/init.c:279:7: warning: no previous extern declaration
      for non-static variable 'early_pg_dir'
      [-Wmissing-variable-declarations]
      279 | pgd_t early_pg_dir[PTRS_PER_PGD] __initdata __aligned(PAGE_SIZE);
          |       ^
      arch/riscv/mm/init.c:279:1: note: declare 'static' if the variable is
      not intended to be used outside of this translation unit
      279 | pgd_t early_pg_dir[PTRS_PER_PGD] __initdata __aligned(PAGE_SIZE);
          | ^
    
    These symbols are referenced by more than one translation unit, so make
    sure they're both declared and include the correct header for their
    declarations. Finally, sort the list of includes to help keep them tidy.
    Reported-by: default avatarkernel test robot <lkp@intel.com>
    Closes: https://lore.kernel.org/llvm/202308081000.tTL1ElTr-lkp@intel.com/Signed-off-by: default avatarNick Desaulniers <ndesaulniers@google.com>
    Link: https://lore.kernel.org/r/20230808-riscv_static-v2-1-2a1e2d2c7a4f@google.com
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarPalmer Dabbelt <palmer@rivosinc.com>
    d2402048
pgtable.h 22.3 KB