• Adrian Bunk's avatar
    [PATCH] SCSI ips: remove inlines · 7c193b27
    Adrian Bunk authored
    Trying to compile drivers/scsi/ips.c with gcc 3.4 and
      # define inline         __inline__ __attribute__((always_inline))
    results in the following error:
    
    <--  snip  -->
    
    ...
      CC      drivers/scsi/ips.o
    drivers/scsi/ips.c: In function `ips_eh_abort':
    drivers/scsi/ips.c:490: sorry, unimplemented: inlining failed in call to
    'ips_removeq_copp': function body not available
    drivers/scsi/ips.c:843: sorry, unimplemented: called from here
    drivers/scsi/ips.c:488: sorry, unimplemented: inlining failed in call to
    'ips_removeq_wait': function body not available
    drivers/scsi/ips.c:847: sorry, unimplemented: called from here
    make[2]: *** [drivers/scsi/ips.o] Error 1
    
    <--  snip  -->
    
    
    The patch below removes all inlines from ips.c. As a side effect, this
    showed that 3 formerly inlined functions are completely unused which are
    also removed in the patch.
    
    An alternative approach to removing the inlines would be to keep all
    inlines that are _really_ required and reorder the functions in the file
    accordingly.
    
    
    diffstat output:
     drivers/scsi/ips.c |  130 ++++++---------------------------------------
     1 files changed, 19 insertions(+), 111 deletions(-)
    Signed-off-by: default avatarAdrian Bunk <bunk@fs.tum.de>
    Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
    7c193b27
ips.c 242 KB