• Xu Jia's avatar
    hamradio: 6pack: fix array-index-out-of-bounds in decode_std_command() · 2b04495e
    Xu Jia authored
    Hulk Robot reports incorrect sp->rx_count_cooked value in decode_std_command().
    This should be caused by the subtracting from sp->rx_count_cooked before.
    It seems that sp->rx_count_cooked value is changed to 0, which bypassed the
    previous judgment.
    
    The situation is shown below:
    
             (Thread 1)			|  (Thread 2)
    decode_std_command()		| resync_tnc()
    ...					|
    if (rest == 2)			|
    	sp->rx_count_cooked -= 2;	|
    else if (rest == 3)			| ...
    					| sp->rx_count_cooked = 0;
    	sp->rx_count_cooked -= 1;	|
    for (i = 0; i < sp->rx_count_cooked; i++) // report error
    	checksum += sp->cooked_buf[i];
    
    sp->rx_count_cooked is a shared variable but is not protected by a lock.
    The same applies to sp->rx_count. This patch adds a lock to fix the bug.
    
    The fail log is shown below:
    =======================================================================
    UBSAN: array-index-out-of-bounds in drivers/net/hamradio/6pack.c:925:31
    index 400 is out of range for type 'unsigned char [400]'
    CPU: 3 PID: 7433 Comm: kworker/u10:1 Not tainted 5.18.0-rc5-00163-g4b97bac0 #2
    Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014
    Workqueue: events_unbound flush_to_ldisc
    Call Trace:
     <TASK>
     dump_stack_lvl+0xcd/0x134
     ubsan_epilogue+0xb/0x50
     __ubsan_handle_out_of_bounds.cold+0x62/0x6c
     sixpack_receive_buf+0xfda/0x1330
     tty_ldisc_receive_buf+0x13e/0x180
     tty_port_default_receive_buf+0x6d/0xa0
     flush_to_ldisc+0x213/0x3f0
     process_one_work+0x98f/0x1620
     worker_thread+0x665/0x1080
     kthread+0x2e9/0x3a0
     ret_from_fork+0x1f/0x30
     ...
    Reported-by: default avatarHulk Robot <hulkci@huawei.com>
    Signed-off-by: default avatarXu Jia <xujia39@huawei.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    2b04495e
6pack.c 23.3 KB