• Colin Xu's avatar
    drm/i915/gvt: Refactor GVT vblank emulator for vGPU virtual display · b01739fb
    Colin Xu authored
    Current vblank emulator uses single hrtimer at 16ms period for all vGPUs,
    which introduces three major issues:
    
    - 16ms matches the refresh rate at 62.5Hz (instead of 60Hz) which
      doesn't follow standard timing. This leads to some frame drop or glitch
      issue during video playback. SW expects a vsync interval of 16.667ms or
      higher precision for an accurate 60Hz refresh rate. However current
      vblank emulator only works at 16ms.
    
    - Doesn't respect the fact that with current virtual EDID timing set,
      not all resolutions are running at 60Hz. For example, current virtual
      EDID also supports refresh rate at 56Hz, 59.97Hz, 60Hz, 75Hz, etc.
    
    - Current vblank emulator use single hrtimer for all vGPUs. Regardsless
      the possibility that different guests could run in different
      resolutions, all vsync interrupts are injected at 16ms interval with
      same hrtimer.
    
    Based on previous patch which decode guest expected refresh rate from
    vreg, the vblank emulator refactor patch makes following changes:
    - Change the vblank emulator hrtimer from gvt global to per-vGPU.
      By doing this, each vGPU display can operates at different refresh
      rates. Currently only one dislay is supported for each vGPU so per-vGPU
      hrtimer is enough. If multiple displays are supported per-vGPU in
      future, we can expand to per-PIPE further.
    - Change the fixed hrtimer period from 16ms to dynamic based on vreg.
      GVT is expected to emulate the HW as close as possible. So reflacting
      the accurate vsync interrupt interval is more correct than fixed 16ms.
    - Change the vblank timer period and start the timer on PIPECONF change.
      The initial period is updated to 16666667 based on 60Hz refresh rate.
      According to PRM, PIPECONF controls the timing generator of the
      connected display on this pipe, so it's safe to stop hrtimer on
      PIPECONF disabling, and re-start hrtimer at new period on enabling.
    
    Other changes including:
    - Move vblank_timer_fn from irq.c into display.c.
    - Clean per-vGPU vblank timer at clean_display instead of clean_irq.
    
    To run quick test, launch a web browser and goto URL: www.displayhz.com
    
    The actual refresh rate from guest can now always match guest settings.
    
    V2:
    Rebase to 5.11.
    Remove unused intel_gvt_clean_irq().
    Simplify enable logic in update_vblank_emulation(). (zhenyu)
    Loop all vGPU by idr when check all vblank timer. (zhenyu)
    Signed-off-by: default avatarColin Xu <colin.xu@intel.com>
    Signed-off-by: default avatarZhenyu Wang <zhenyuw@linux.intel.com>
    Link: http://patchwork.freedesktop.org/patch/msgid/20210226044630.284269-1-colin.xu@intel.comReviewed-by: default avatarZhenyu Wang <zhenyuw@linux.intel.com>
    b01739fb
interrupt.h 5.98 KB