• Mathieu Desnoyers's avatar
    selftests/rseq: Use rseq_unqual_scalar_typeof in macros · 2b2fe605
    Mathieu Desnoyers authored
    Use rseq_unqual_scalar_typeof() rather than typeof() in macros to remove
    the volatile qualifier (if there is one in the input argument), thus
    generating better assembly code in those scenarios.
    
    Also add extra brackets around the "p" parameter in RSEQ_READ_ONCE(),
    RSEQ_WRITE_ONCE(), and rseq_unqual_scalar_typeof() across architectures
    to preserve expectations of operator priority. Here is an example that
    shows how operator priority may be an issue with missing parentheses:
    
        #define m(p) \
        do { \
                __typeof__(*p) v = 0; \
        } while (0)
    
        void fct(unsigned long long *p1)
        {
                m(p1 + 1);      /* works */
                m(1 + p1);      /* broken */
        }
    Signed-off-by: default avatarMathieu Desnoyers <mathieu.desnoyers@efficios.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
    2b2fe605
rseq-mips.h 5.42 KB