• Johannes Weiner's avatar
    mm: vmstat: fix NOHZ wakeups for node stat changes · 2bbd00ae
    Johannes Weiner authored
    On NOHZ, the periodic vmstat flushers on each CPU can go to sleep and
    won't wake up until stat changes are detected in the per-cpu deltas of the
    zone vmstat counters.
    
    In commit 75ef7184 ("mm, vmstat: add infrastructure for per-node
    vmstats") per-node counters were introduced, and subsequently most stats
    were moved from the zone to the node level.  However, the node counters
    weren't added to the NOHZ wakeup detection.
    
    In theory this can cause per-cpu errors to remain in the user-reported
    stats indefinitely.  In practice this only affects a handful of sub
    counters (file_mapped, dirty and writeback e.g.) because other page state
    changes at the node level likely involve a change at the zone level as
    well (alloc and free, lru ops).  Also, nobody has complained.
    
    Fix it up for completeness: wake up vmstat refreshing on node changes.
    Also remove the BUILD_BUG_ONs that assert counter size; we haven't relied
    on it since we added sizeof() to the range calculation in commit
    13c9aaf7 ("mm/vmstat.c: fix NUMA statistics updates").
    
    Link: https://lkml.kernel.org/r/20210202184342.118513-1-hannes@cmpxchg.orgSigned-off-by: default avatarJohannes Weiner <hannes@cmpxchg.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    2bbd00ae
vmstat.c 53.4 KB