• Steven Rostedt's avatar
    fgraph: Use CPU hotplug mechanism to initialize idle shadow stacks · 2c02f737
    Steven Rostedt authored
    The function graph infrastructure allocates a shadow stack for every task
    when enabled. This includes the idle tasks. The first time the function
    graph is invoked, the shadow stacks are created and never freed until the
    task exits. This includes the idle tasks.
    
    Only the idle tasks that were for online CPUs had their shadow stacks
    created when function graph tracing started. If function graph tracing is
    enabled and a CPU comes online, the idle task representing that CPU will
    not have its shadow stack created, and all function graph tracing for that
    idle task will be silently dropped.
    
    Instead, use the CPU hotplug mechanism to allocate the idle shadow stacks.
    This will include idle tasks for CPUs that come online during tracing.
    
    This issue can be reproduced by:
    
     # cd /sys/kernel/tracing
     # echo 0 > /sys/devices/system/cpu/cpu1/online
     # echo 0 > set_ftrace_pid
     # echo function_graph > current_tracer
     # echo 1 > options/funcgraph-proc
     # echo 1 > /sys/devices/system/cpu/cpu1
     # grep '<idle>' per_cpu/cpu1/trace | head
    
    Before, nothing would show up.
    
    After:
     1)    <idle>-0    |   0.811 us    |                        __enqueue_entity();
     1)    <idle>-0    |   5.626 us    |                      } /* enqueue_entity */
     1)    <idle>-0    |               |                      dl_server_update_idle_time() {
     1)    <idle>-0    |               |                        dl_scaled_delta_exec() {
     1)    <idle>-0    |   0.450 us    |                          arch_scale_cpu_capacity();
     1)    <idle>-0    |   1.242 us    |                        }
     1)    <idle>-0    |   1.908 us    |                      }
     1)    <idle>-0    |               |                      dl_server_start() {
     1)    <idle>-0    |               |                        enqueue_dl_entity() {
     1)    <idle>-0    |               |                          task_contending() {
    
    Note, if tracing stops and restarts, the old way would then initialize
    the onlined CPUs.
    
    Cc: stable@vger.kernel.org
    Cc: Masami Hiramatsu <mhiramat@kernel.org>
    Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Link: https://lore.kernel.org/20241018214300.6df82178@rorschach
    Fixes: 868baf07 ("ftrace: Fix memory leak with function graph and cpu hotplug")
    Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
    2c02f737
fgraph.c 37.6 KB