• Daniel Borkmann's avatar
    bpf: fix byte order test in test_verifier · 2c460621
    Daniel Borkmann authored
    We really must check with #if __BYTE_ORDER == XYZ instead of
    just presence of #ifdef __LITTLE_ENDIAN. I noticed that when
    actually running this on big endian machine, the latter test
    resolves to true for user space, same for #ifdef __BIG_ENDIAN.
    
    E.g., looking at endian.h from libc, both are also defined
    there, so we really must test this against __BYTE_ORDER instead
    for proper insns selection. For the kernel, such checks are
    fine though e.g. see 13da9e20 ("Revert "endian: #define
    __BYTE_ORDER"") and 415586c9 ("UAPI: fix endianness conditionals
    in M32R's asm/stat.h") for some more context, but not for
    user space. Lets also make sure to properly include endian.h.
    After that, suite passes for me:
    
    ./test_verifier: ELF 64-bit MSB executable, [...]
    
    Linux foo 4.13.0-rc3+ #4 SMP Fri Aug 4 06:59:30 EDT 2017 s390x s390x s390x GNU/Linux
    
    Before fix: Summary: 505 PASSED, 11 FAILED
    After  fix: Summary: 516 PASSED,  0 FAILED
    
    Fixes: 18f3d6be ("selftests/bpf: Add test cases to test narrower ctx field loads")
    Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
    Acked-by: default avatarYonghong <yhs@fb.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    2c460621
test_verifier.c 189 KB