• Theodore Y. Ts'o's avatar
    [PATCH] ext3 htree telldir() fix · 2f0f10bb
    Theodore Y. Ts'o authored
    telldir() is broken on large ext3 dir_index'd directories because
    getdents() gives d_off==0 for the first entry
    
    Here's a patch which fixes the problem, but note the following warning
    from the readdir man page:
    
           According to POSIX, the dirent structure contains a field char d_name[]
           of  unspecified  size,  with  at most NAME_MAX characters preceding the
           terminating null character.  Use of other fields will harm  the  porta-
           bility  of  your  programs.
    
    Also, as always, telldir() and seekdir() are truly awful interfaces
    because they implicitly assume that (a) a directory is a linear data
    structure, and (b) that the position in a directory can be expressed
    in a cookie which hsa only 31 bits on 32-bit systems. 
    
    So there will be hash colliions that will cause programs that assume
    that seekdir(dirent->d_off) will always return the next directory
    entry to sometimes lose directory entries in the
    not-as-unlikely-as-we-would wish case of a 31-bit hash collision.
    Really, any program which is using telldir/seekdir really should be
    rewritten to not use these interfaces if at all possible.  So with
    these caveats....
    
    
    What we need to do is wire '.' and '..' to have hash values of (0,0) and
    (2,0), respectively, without ignoring other existing dirents with colliding
    hashes.  (In those cases the programs will break, but they are statistically
    rare, and there's not much we can do in those cases anyway.)
    Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    2f0f10bb
namei.c 63.6 KB