• Tejun Heo's avatar
    charger_manager: Don't use [delayed_]work_pending() · 2fbb520d
    Tejun Heo authored
    There's no need to test whether a (delayed) work item in pending
    before queueing, flushing or cancelling it.  Most uses are unnecessary
    and quite a few of them are buggy.
    
    Remove unnecessary pending tests and rewrite _setup_polling() so that
    it uses mod_delayed_work() if the next polling interval is sooner than
    currently scheduled.  queue_delayed_work() is used otherwise.
    
    Only compile tested.  I noticed that two work items - setup_polling
    and cm_monitor_work - schedule each other.  It's a very unusual
    construct and I'm fairly sure it's racy.  You can't break such
    circular dependency by calling cancel on each.  I strongly recommend
    revising the mechanism.
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    Cc: Anton Vorontsov <cbou@mail.ru>
    Cc: David Woodhouse <dwmw2@infradead.org>
    Cc: Donggeun Kim <dg77.kim@samsung.com>
    Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
    Signed-off-by: default avatarAnton Vorontsov <anton.vorontsov@linaro.org>
    2fbb520d
charger-manager.c 50.5 KB