• Xiongwei Song's avatar
    locking/lockdep: Fix meaningless /proc/lockdep output of lock classes on !CONFIG_PROVE_LOCKING · 4840ce22
    Xiongwei Song authored
    When enabling CONFIG_LOCK_STAT=y, then CONFIG_LOCKDEP=y is forcedly enabled,
    but CONFIG_PROVE_LOCKING is disabled.
    
    We can get output from /proc/lockdep, which currently includes usages of
    lock classes. But the usages are meaningless, see the output below:
    
    	/ # cat /proc/lockdep
    	all lock classes:
    	ffffffff9af63350 ....: cgroup_mutex
    
    	ffffffff9af54eb8 ....: (console_sem).lock
    
    	ffffffff9af54e60 ....: console_lock
    
    	ffffffff9ae74c38 ....: console_owner_lock
    
    	ffffffff9ae74c80 ....: console_owner
    
    	ffffffff9ae66e60 ....: cpu_hotplug_lock
    
    Only one usage context for each lock, this is because each usage is only
    changed in mark_lock() that is in the CONFIG_PROVE_LOCKING=y section,
    however in the test situation, it's not.
    
    The fix is to move the usages reading and seq_print from the
    !CONFIG_PROVE_LOCKING section to its defined section.
    
    Also, locks_after list of lock_class is empty when !CONFIG_PROVE_LOCKING,
    so do the same thing as what have done for usages of lock classes.
    
    With this patch with !CONFIG_PROVE_LOCKING we can get the results below:
    
    	/ # cat /proc/lockdep
    	all lock classes:
    	ffffffff85163290: cgroup_mutex
    	ffffffff85154dd8: (console_sem).lock
    	ffffffff85154d80: console_lock
    	ffffffff85074b58: console_owner_lock
    	ffffffff85074ba0: console_owner
    	ffffffff85066d60: cpu_hotplug_lock
    
    ... a class key and the relevant class name each line.
    Signed-off-by: default avatarXiongwei Song <sxwjean@gmail.com>
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    Acked-by: default avatarWaiman Long <longman@redhat.com>
    Link: https://lore.kernel.org/r/20210629135916.308210-1-sxwjean@me.com
    4840ce22
lockdep_proc.c 17.8 KB