• Matthew Wilcox (Oracle)'s avatar
    XArray: Do not return sibling entries from xa_load() · cbc02854
    Matthew Wilcox (Oracle) authored
    It is possible for xa_load() to observe a sibling entry pointing to
    another sibling entry.  An example:
    
    Thread A:		Thread B:
    			xa_store_range(xa, entry, 188, 191, gfp);
    xa_load(xa, 191);
    entry = xa_entry(xa, node, 63);
    [entry is a sibling of 188]
    			xa_store_range(xa, entry, 184, 191, gfp);
    if (xa_is_sibling(entry))
    offset = xa_to_sibling(entry);
    entry = xa_entry(xas->xa, node, offset);
    [entry is now a sibling of 184]
    
    It is sufficient to go around this loop until we hit a non-sibling entry.
    Sibling entries always point earlier in the node, so we are guaranteed
    to terminate this search.
    Signed-off-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
    Fixes: 6b24ca4a ("mm: Use multi-index entries in the page cache")
    Cc: stable@vger.kernel.org
    cbc02854
multiorder.c 6.61 KB