• Ian Rogers's avatar
    perf tools: Revert enable indices setting syntax for BPF map · 30f4ade3
    Ian Rogers authored
    This reverts commit e571e029 ("perf tools: Enable indices setting
    syntax for BPF map").
    
    The reverted commit added a notion of arrays that could be set as
    event terms for BPF events. The parsing hasn't worked over multiple
    Linux releases. Given the broken nature of the parsing it appears the
    code isn't in use, nor could I find a way for it to be used to add a
    test.
    
    The original commit contains a test in the commit message,
    however, running it yields:
    ```
    $ perf record -e './test_bpf_map_3.c/map:channel.value[0,1,2,3...5]=101/' usleep 2
    event syntax error: '..pf_map_3.c/map:channel.value[0,1,2,3...5]=101/'
                                      \___ parser error
    Run 'perf list' for a list of valid events
    
     Usage: perf record [<options>] [<command>]
        or: perf record [<options>] -- <command> [<options>]
    
        -e, --event <event>   event selector. use 'perf list' to list available events
    ```
    
    Given the code can't be used this commit reverts and removes it.
    Signed-off-by: default avatarIan Rogers <irogers@google.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Eduard Zingerman <eddyz87@gmail.com>
    Cc: He Kuang <hekuang@huawei.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Kan Liang <kan.liang@linux.intel.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Rob Herring <robh@kernel.org>
    Cc: Wang Nan <wangnan0@huawei.com>
    Cc: Wang ShaoBo <bobo.shaobowang@huawei.com>
    Cc: YueHaibing <yuehaibing@huawei.com>
    Cc: bpf@vger.kernel.org
    Link: https://lore.kernel.org/r/20230728001212.457900-3-irogers@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    30f4ade3
parse-events.c 71.4 KB