• Arnd Bergmann's avatar
    phy: mscc: fix printf format · 31bae7da
    Arnd Bergmann authored
    gcc points out that the length of the temporary buffer may not be sufficient for
    large numbers of leds:
    
    drivers/net/phy/mscc.c: In function 'vsc85xx_probe':
    drivers/net/phy/mscc.c:460:45: error: '-mode' directive writing 5 bytes into a region of size between 0 and 9 [-Werror=format-overflow=]
       ret = sprintf(led_dt_prop, "vsc8531,led-%d-mode", i);
                                                 ^~~~~
    drivers/net/phy/mscc.c:460:9: note: 'sprintf' output between 19 and 28 bytes into a destination of size 22
       ret = sprintf(led_dt_prop, "vsc8531,led-%d-mode", i);
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    While we can make a reasonable assumption that the number of LEDs is small,
    the cost of making the buffer a little bigger is insignificant as well.
    
    Fixes: 11bfdabb ("net: phy: mscc: factorize code for LEDs mode")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Reviewed-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    31bae7da
mscc.c 19.9 KB