• Arnd Bergmann's avatar
    crypto: octeontx2 - fix -Wpointer-bool-conversion warning · 6956d8be
    Arnd Bergmann authored
    When CONFIG_CPUMASK_OFFSTACK is disabled, clang reports a warning
    about a bogus condition:
    
    drivers/crypto/marvell/octeontx2/otx2_cptlf.c:334:21: error: address of array 'lfs->lf[slot].affinity_mask' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                    if (lfs->lf[slot].affinity_mask)
                    ~~  ~~~~~~~~~~~~~~^~~~~~~~~~~~~
    
    In this configuration, the free_cpumask_var() function does nothing,
    so the condition could be skipped.
    
    When the option is enabled, there is no warning, but the check
    is also redundant because free_cpumask_var() falls back to kfree(),
    which is documented as ignoring NULL pointers.
    
    Remove the check to avoid the warning.
    
    Fixes: 64506017 ("crypto: octeontx2 - add LF framework")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Reviewed-by: default avatarNathan Chancellor <nathan@kernel.org>
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    6956d8be
otx2_cptlf.c 10.6 KB