• Amitoj Kaur Chawla's avatar
    of: resolver: Add missing of_node_get and of_node_put · 82f68756
    Amitoj Kaur Chawla authored
    In __of_find_node_by_full_name, add an of_node_get when detecting the
    desired element, to ensure that it ends up with a reference count that is
    one greater than on entering the function.
    
    Also in __of_find_node_by_full_name, add an of_node_put on breaking
    out of the for_each_child_of_node loop, to ensure that the reference
    count of the returned value is not double incremented. This change
    was made using Coccinelle.
    
    The semantic patch used for this is as follows:
    
    // <smpl>
    @@
    expression e;
    local idexpression n;
    @@
    
     for_each_child_of_node(..., n) {
       ... when != of_node_put(n)
           when != e = n
    (
       return n;
    |
    +  of_node_put(n);
    ?  return ...;
    )
       ...
     }
    // </smpl
    
    Finally, add an of_node_put in for_each_child_of_node in the function
    __of_adjust_phandle_ref after the value returned by
    __of_find_node_by_full_name is no longer useful.
    Signed-off-by: default avatarAmitoj Kaur Chawla <amitoj1606@gmail.com>
    Signed-off-by: default avatarRob Herring <robh@kernel.org>
    82f68756
resolver.c 10.2 KB