• Rasmus Villemoes's avatar
    efi: cper: fix snprintf() use in cper_dimm_err_location() · 942859d9
    Rasmus Villemoes authored
    snprintf() should be given the full buffer size, not one less. And it
    guarantees nul-termination, so doing it manually afterwards is
    pointless.
    
    It's even potentially harmful (though probably not in practice because
    CPER_REC_LEN is 256), due to the "return how much would have been
    written had the buffer been big enough" semantics. I.e., if the bank
    and/or device strings are long enough that the "DIMM location ..."
    output gets truncated, writing to msg[n] is a buffer overflow.
    Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
    Fixes: 3760cd20 ("CPER: Adjust code flow of some functions")
    Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
    942859d9
cper.c 20.3 KB