• Florian Westphal's avatar
    netfilter: conntrack: fix IPV6=n builds · 81e01647
    Florian Westphal authored
    Stephen Rothwell reports:
     After merging the netfilter-next tree, today's linux-next build
     (powerpc ppc64_defconfig) failed like this:
    
     ERROR: "nf_conntrack_invert_icmpv6_tuple" [nf_conntrack.ko] undefined!
     ERROR: "nf_conntrack_icmpv6_packet" [nf_conntrack.ko] undefined!
     ERROR: "nf_conntrack_icmpv6_init_net" [nf_conntrack.ko] undefined!
     ERROR: "icmpv6_pkt_to_tuple" [nf_conntrack.ko] undefined!
     ERROR: "nf_ct_gre_keymap_destroy" [nf_conntrack.ko] undefined!
    
    icmpv6 related errors are due to lack of IS_ENABLED(CONFIG_IPV6) (no
    icmpv6 support is builtin if kernel has CONFIG_IPV6=n), the
    nf_ct_gre_keymap_destroy error is due to lack of PROTO_GRE check.
    
    Fixes: a47c5404 ("netfilter: conntrack: handle builtin l4proto packet functions via direct calls")
    Fixes: e2e48b47 ("netfilter: conntrack: handle icmp pkt_to_tuple helper via direct calls")
    Fixes: 197c4300 ("netfilter: conntrack: remove invert_tuple callback")
    Fixes: 2a389de8 ("netfilter: conntrack: remove l4proto init and get_net callbacks")
    Fixes: e5689435 ("netfilter: conntrack: remove l4proto destroy hook")
    Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
    Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
    81e01647
nf_conntrack_proto.c 15 KB