• Alan Stern's avatar
    [PATCH] USB storage: Add comments explaining new s-g usage · 343f4be5
    Alan Stern authored
    On Sun, 30 Nov 2003, Matthew Dharm wrote:
    > I'm going to pass this one along to Greg, but I think some places in this
    > could really use some better comments.  Especially the way you use a single
    > buffer inside the loop -- it took me a few minutes to figure out how your
    > logic to refresh the buffer with new data worked.
    >
    > I'm also wondering if the access_xfer_buf() function could use some more
    > header comments, stating why this is needed (i.e. spelling out the
    > kmap()-isms).
    
    Okay, here it is.  This patch basically just adds comments.  Each routine
    that uses the new scatter-gather function gets a brief explanation of
    what's going on, and access_xfer_buf() itself gets detailed comments
    saying what it's doing and why it's necessary.  You may even want to cut
    some of it back; I was pretty verbose.
    343f4be5
sddr55.c 24.1 KB