• Guenter Roeck's avatar
    brcmsmac: Drop unnecessary NULL check after container_of · 34fe7038
    Guenter Roeck authored
    The parameter passed to ai_detach() is guaranteed to never be NULL
    because it is checked by the caller. Consequently, the result of
    container_of() on it is also never NULL, and a NULL check on it
    is unnecessary. Even without that, the NULL check would still be
    unnecessary because the subsequent kfree() can handle NULL arguments.
    On top of all that, it is misleading to check the result of container_of()
    against NULL because the position of the contained element could change,
    which would make the check invalid. Remove it.
    
    This change was made automatically with the following Coccinelle script.
    
    @@
    type t;
    identifier v;
    statement s;
    @@
    
    <+...
    (
      t v = container_of(...);
    |
      v = container_of(...);
    )
      ...
      when != v
    - if (\( !v \| v == NULL \) ) s
    ...+>
    Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
    Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
    Link: https://lore.kernel.org/r/20210511235629.1686038-1-linux@roeck-us.net
    34fe7038
aiutils.c 19.2 KB