• Thomas Gleixner's avatar
    powerpc/smp: Replace open coded task affinity logic · 6d11b87d
    Thomas Gleixner authored
    Init task invokes smp_ops->setup_cpu() from smp_cpus_done(). Init task can
    run on any online CPU at this point, but the setup_cpu() callback requires
    to be invoked on the boot CPU. This is achieved by temporarily setting the
    affinity of the calling user space thread to the requested CPU and reset it
    to the original affinity afterwards.
    
    That's racy vs. CPU hotplug and concurrent affinity settings for that
    thread resulting in code executing on the wrong CPU and overwriting the
    new affinity setting.
    
    That's actually not a problem in this context as neither CPU hotplug nor
    affinity settings can happen, but the access to task_struct::cpus_allowed
    is about to restricted.
    
    Replace it with a call to work_on_cpu_safe() which achieves the same result.
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Acked-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    Cc: Fenghua Yu <fenghua.yu@intel.com>
    Cc: Tony Luck <tony.luck@intel.com>
    Cc: Herbert Xu <herbert@gondor.apana.org.au>
    Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    Cc: Sebastian Siewior <bigeasy@linutronix.de>
    Cc: Lai Jiangshan <jiangshanlai@gmail.com>
    Cc: Viresh Kumar <viresh.kumar@linaro.org>
    Cc: Tejun Heo <tj@kernel.org>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: linuxppc-dev@lists.ozlabs.org
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: Len Brown <lenb@kernel.org>
    Link: http://lkml.kernel.org/r/20170412201042.518053336@linutronix.deSigned-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    6d11b87d
smp.c 18.8 KB