• Li Zhijian's avatar
    cxl/region: Fix cxl_region_rwsem lock held when returning to user space · 3531b27f
    Li Zhijian authored
    Fix a missed "goto out" to unlock on error to cleanup this splat:
    
        WARNING: lock held when returning to user space!
        6.6.0-rc3-lizhijian+ #213 Not tainted
        ------------------------------------------------
        cxl/673 is leaving the kernel with locks still held!
        1 lock held by cxl/673:
         #0: ffffffffa013b9d0 (cxl_region_rwsem){++++}-{3:3}, at: commit_store+0x7d/0x3e0 [cxl_core]
    
    In terms of user visible impact of this bug for backports:
    
    cxl_region_invalidate_memregion() on x86 invokes wbinvd which is a
    problematic instruction for virtualized environments. So, on virtualized
    x86, cxl_region_invalidate_memregion() returns an error. This failure
    case got missed because CXL memory-expander device passthrough is not a
    production use case, and emulation of CXL devices is typically limited
    to kernel development builds with CONFIG_CXL_REGION_INVALIDATION_TEST=y,
    that makes cxl_region_invalidate_memregion() succeed.
    
    In other words, the expected exposure of this bug is limited to CXL
    subsystem development environments using QEMU that neglected
    CONFIG_CXL_REGION_INVALIDATION_TEST=y.
    
    Fixes: d1257d09 ("cxl/region: Move cache invalidation before region teardown, and before setup")
    Signed-off-by: default avatarLi Zhijian <lizhijian@fujitsu.com>
    Reviewed-by: default avatarIra Weiny <ira.weiny@intel.com>
    Link: https://lore.kernel.org/r/20231025085450.2514906-1-lizhijian@fujitsu.comSigned-off-by: default avatarDan Williams <dan.j.williams@intel.com>
    3531b27f
region.c 73.1 KB