• Robert Richter's avatar
    perf tools: Unify handling of features when writing feature section · e20960c0
    Robert Richter authored
    The features HEADER_TRACE_INFO and HEADER_BUILD_ID are handled
    different when writing the feature section. All other features are
    simply disabled on failure and writing the section goes on without
    returning an error. There is no reason for these special cases. This
    patch unifies handling of the features.
    
    This should be ok since all features can be parsed independently.
    Offset and size of a feature's block is stored in struct perf_file_
    section right after the data block of perf.data (see perf_session__
    write_header()). Thus, if a feature does not exist then other features
    can be processed anyway.
    
    Also moving special code for HEADER_BUILD_ID out to write_build_id().
    
    v2:
    * perf record throws an error now if buildids may not be generated,
      which can be disabled with the --no-buildid option.
    
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Link: http://lkml.kernel.org/r/1323248577-11268-6-git-send-email-robert.richter@amd.comSigned-off-by: default avatarRobert Richter <robert.richter@amd.com>
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    e20960c0
builtin-record.c 23 KB