• lucien's avatar
    netfilter: ipt_rpfilter: remove the nh_scope test in rpfilter_lookup_reverse · cc4998fe
    lucien authored
    --accept-local  option works for res.type == RTN_LOCAL, which should be
    from the local table, but there, the fib_info's nh->nh_scope =
    RT_SCOPE_NOWHERE ( > RT_SCOPE_HOST). in fib_create_info().
    
    	if (cfg->fc_scope == RT_SCOPE_HOST) {
    		struct fib_nh *nh = fi->fib_nh;
    
    		/* Local address is added. */
    		if (nhs != 1 || nh->nh_gw)
    			goto err_inval;
    		nh->nh_scope = RT_SCOPE_NOWHERE;   <===
    		nh->nh_dev = dev_get_by_index(net, fi->fib_nh->nh_oif);
    		err = -ENODEV;
    		if (!nh->nh_dev)
    			goto failure;
    
    but in our rpfilter_lookup_reverse():
    
    	if (dev_match || flags & XT_RPFILTER_LOOSE)
    		return FIB_RES_NH(res).nh_scope <= RT_SCOPE_HOST;
    
    if nh->nh_scope > RT_SCOPE_HOST, it will fail. --accept-local option
    will never be passed.
    
    it seems the test is bogus and can be removed to fix this issue.
    
    	if (dev_match || flags & XT_RPFILTER_LOOSE)
    		return FIB_RES_NH(res).nh_scope <= RT_SCOPE_HOST;
    
    ipv6 does not have this issue.
    Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
    Acked-by: default avatarFlorian Westphal <fw@strlen.de>
    Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
    cc4998fe
ipt_rpfilter.c 3.57 KB