• Paul Mackerras's avatar
    perf_event: Adjust frequency and unthrottle for non-group-leader events · 03541f8b
    Paul Mackerras authored
    The loop in perf_ctx_adjust_freq checks the frequency of sampling
    event counters, and adjusts the event interval and unthrottles the
    event if required, and resets the interrupt count for the event.
    However, at present it only looks at group leaders.
    
    This means that a sampling event that is not a group leader will
    eventually get throttled, once its interrupt count reaches
    sysctl_perf_event_sample_rate/HZ --- and that is guaranteed to
    happen, if the event is active for long enough, since the interrupt
    count never gets reset.  Once it is throttled it never gets
    unthrottled, so it basically just stops working at that point.
    
    This fixes it by making perf_ctx_adjust_freq use ctx->event_list
    rather than ctx->group_list.  The existing spin_lock/spin_unlock
    around the loop makes it unnecessary to put rcu_read_lock/
    rcu_read_unlock around the list_for_each_entry_rcu().
    Reported-by: default avatarMark W. Krentel <krentel@cs.rice.edu>
    Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
    Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    LKML-Reference: <19157.26731.855609.165622@cargo.ozlabs.ibm.com>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    03541f8b
perf_event.c 116 KB