• Chris Wilson's avatar
    drm/i915: Complete the fences as they are cancelled due to wedging · 3800960a
    Chris Wilson authored
    We inspect the requests under the assumption that they will be marked as
    completed when they are removed from the queue. Currently however, in the
    process of wedging the requests will be removed from the queue before they
    are completed, so rearrange the code to complete the fences before the
    locks are dropped.
    
    <1>[  354.473346] BUG: unable to handle kernel NULL pointer dereference at 0000000000000250
    <6>[  354.473363] PGD 0 P4D 0
    <4>[  354.473370] Oops: 0000 [#1] PREEMPT SMP PTI
    <4>[  354.473380] CPU: 0 PID: 4470 Comm: gem_eio Tainted: G     U            4.20.0-rc4-CI-CI_DRM_5216+ #1
    <4>[  354.473393] Hardware name: Intel Corporation NUC7CJYH/NUC7JYB, BIOS JYGLKCPX.86A.0027.2018.0125.1347 01/25/2018
    <4>[  354.473480] RIP: 0010:__i915_schedule+0x311/0x5e0 [i915]
    <4>[  354.473490] Code: 49 89 44 24 20 4d 89 4c 24 28 4d 89 29 44 39 b3 a0 04 00 00 7d 3a 41 8b 44 24 78 85 c0 74 13 48 8b 93 78 04 00 00 48 83 e2 fc <39> 82 50 02 00 00 79 1e 44 89 b3 a0 04 00 00 48 8d bb d0 03 00 00
    <4>[  354.473515] RSP: 0018:ffffc900001bba90 EFLAGS: 00010046
    <4>[  354.473524] RAX: 0000000000000003 RBX: ffff8882624c8008 RCX: f34a737800000000
    <4>[  354.473535] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff8882624c8048
    <4>[  354.473545] RBP: ffffc900001bbab0 R08: 000000005963f1f1 R09: 0000000000000000
    <4>[  354.473556] R10: ffffc900001bba10 R11: ffff8882624c8060 R12: ffff88824fdd7b98
    <4>[  354.473567] R13: ffff88824fdd7bb8 R14: 0000000000000001 R15: ffff88824fdd7750
    <4>[  354.473578] FS:  00007f44b4b5b980(0000) GS:ffff888277e00000(0000) knlGS:0000000000000000
    <4>[  354.473590] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
    <4>[  354.473599] CR2: 0000000000000250 CR3: 000000026976e000 CR4: 0000000000340ef0
    <4>[  354.473611] Call Trace:
    <4>[  354.473622]  ? lock_acquire+0xa6/0x1c0
    <4>[  354.473677]  ? i915_schedule_bump_priority+0x57/0xd0 [i915]
    <4>[  354.473736]  i915_schedule_bump_priority+0x72/0xd0 [i915]
    <4>[  354.473792]  i915_request_wait+0x4db/0x840 [i915]
    <4>[  354.473804]  ? get_pwq.isra.4+0x2c/0x50
    <4>[  354.473813]  ? ___preempt_schedule+0x16/0x18
    <4>[  354.473824]  ? wake_up_q+0x70/0x70
    <4>[  354.473831]  ? wake_up_q+0x70/0x70
    <4>[  354.473882]  ? gen6_rps_boost+0x118/0x120 [i915]
    <4>[  354.473936]  i915_gem_object_wait_fence+0x8a/0x110 [i915]
    <4>[  354.473991]  i915_gem_object_wait+0x113/0x500 [i915]
    <4>[  354.474047]  i915_gem_wait_ioctl+0x11c/0x2f0 [i915]
    <4>[  354.474101]  ? i915_gem_unset_wedged+0x210/0x210 [i915]
    <4>[  354.474113]  drm_ioctl_kernel+0x81/0xf0
    <4>[  354.474123]  drm_ioctl+0x2de/0x390
    <4>[  354.474175]  ? i915_gem_unset_wedged+0x210/0x210 [i915]
    <4>[  354.474187]  ? finish_task_switch+0x95/0x260
    <4>[  354.474197]  ? lock_acquire+0xa6/0x1c0
    <4>[  354.474207]  do_vfs_ioctl+0xa0/0x6e0
    <4>[  354.474217]  ? __fget+0xfc/0x1e0
    <4>[  354.474225]  ksys_ioctl+0x35/0x60
    <4>[  354.474233]  __x64_sys_ioctl+0x11/0x20
    <4>[  354.474241]  do_syscall_64+0x55/0x190
    <4>[  354.474251]  entry_SYSCALL_64_after_hwframe+0x49/0xbe
    <4>[  354.474260] RIP: 0033:0x7f44b3de65d7
    <4>[  354.474267] Code: b3 66 90 48 8b 05 b1 48 2d 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 81 48 2d 00 f7 d8 64 89 01 48
    <4>[  354.474293] RSP: 002b:00007fff974948e8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
    <4>[  354.474305] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f44b3de65d7
    <4>[  354.474316] RDX: 00007fff97494940 RSI: 00000000c010646c RDI: 0000000000000007
    <4>[  354.474327] RBP: 00007fff97494940 R08: 0000000000000000 R09: 00007f44b40bbc40
    <4>[  354.474337] R10: 0000000000000000 R11: 0000000000000246 R12: 00000000c010646c
    <4>[  354.474348] R13: 0000000000000007 R14: 0000000000000000 R15: 0000000000000000
    
    v2: Avoid floating requests.
    v3: Can't call dma_fence_signal() under the timeline lock!
    v4: Can't call dma_fence_signal() from inside another fence either.
    Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
    Reviewed-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20181203113701.12106-2-chris@chris-wilson.co.uk
    3800960a
intel_ringbuffer.c 59.9 KB